Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Rudderstack for event tracking #46

Merged
merged 1 commit into from
Aug 2, 2023
Merged

chore: add Rudderstack for event tracking #46

merged 1 commit into from
Aug 2, 2023

Conversation

nsalamad
Copy link
Contributor

@nsalamad nsalamad commented Aug 1, 2023

Changes

  • Add RudderStack for event tracking
  • sendMetrics setting is now defaulted to false
  • Add task to generate analytics.ts file if one does on exist on launch

@nsalamad nsalamad force-pushed the DVC-8181-add-rudderstack branch 6 times, most recently from 465599a to 8d03726 Compare August 1, 2023 20:09
@nsalamad nsalamad force-pushed the DVC-8181-add-rudderstack branch 3 times, most recently from d3c8c62 to 9b03c55 Compare August 1, 2023 20:28
laurawarr
laurawarr reviewed Aug 2, 2023
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
laurawarr
laurawarr reviewed Aug 2, 2023
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
@nsalamad nsalamad force-pushed the DVC-8181-add-rudderstack branch 2 times, most recently from 2585755 to 45e7ffd Compare August 2, 2023 20:32
laurawarr
laurawarr reviewed Aug 2, 2023
View reviewed changes
src/RudderStackService.ts Outdated Show resolved Hide resolved
laurawarr
laurawarr approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@laurawarr laurawarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo, otherwise looks good

@nsalamad nsalamad force-pushed the DVC-8181-add-rudderstack branch 2 times, most recently from ede3142 to 5d62e1b Compare August 2, 2023 21:31
@nsalamad nsalamad merged commit 65f4e77 into main Aug 2, 2023
1 check passed
@laurawarr laurawarr deleted the DVC-8181-add-rudderstack branch August 11, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurawarr laurawarr laurawarr approved these changes

@elliotCamblor elliotCamblor Awaiting requested review from elliotCamblor

@emmawillis emmawillis Awaiting requested review from emmawillis

@L-Joli L-Joli Awaiting requested review from L-Joli

@jsalaber jsalaber Awaiting requested review from jsalaber

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsalamad @jsalaber @laurawarr